From 56cd5218a61d7365e501b57d8d79330ffa696031 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Fri, 27 Mar 2026 17:37:31 +0100 Subject: [PATCH] lsi53c895a: keep a reference to the device while SCRIPTS execute SCRIPTS execution can trigger PCI device unplug and consequently a use-after-free after the unplug returns. Avoid this by keeping the device alive. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3090 CVE: CVE-2024-6519 Upstream-Status: Backport [https://gitlab.com/qemu-project/qemu/-/commit/4862d2c95104d9fd0430cc003c205094f8ada1f9] Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit 4862d2c95104d9fd0430cc003c205094f8ada1f9) Signed-off-by: Deepak Rathore --- hw/scsi/lsi53c895a.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 9ea4aa0a853..2cc7e945e16 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1163,6 +1163,7 @@ static void lsi_execute_script(LSIState *s) s->waiting = LSI_NOWAIT; } + object_ref(s); reentrancy_level++; s->istat1 |= LSI_ISTAT1_SRUN; @@ -1182,6 +1183,7 @@ again: s->waiting = LSI_WAIT_SCRIPTS; lsi_scripts_timer_start(s); reentrancy_level--; + object_unref(s); return; } insn = read_dword(s, s->dsp); @@ -1630,6 +1632,7 @@ again: trace_lsi_execute_script_stop(); reentrancy_level--; + object_unref(s); } static uint8_t lsi_reg_readb(LSIState *s, int offset) -- 2.35.6